Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-3002] Update Go dependencies for CVE fixes #1005

Closed
wants to merge 1 commit into from

Conversation

blueBlue0102
Copy link
Contributor

What is this PR for?

Update Go dependencies for CVE fixes

  • golang.org/x/crypto from v0.26.0 to v0.31.0
  • golang.org/x/net from v0.28.0 to v0.33.0

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

YUNIKORN-3002

How should this be tested?

Successfully passed the unit test locally

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.97%. Comparing base (149820f) to head (779dac7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          97       97           
  Lines       15621    15621           
=======================================
  Hits        12806    12806           
  Misses       2537     2537           
  Partials      278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueBlue0102 Could you please check the CI error. Thanks!

@craigcondit
Copy link
Contributor

craigcondit commented Dec 19, 2024

@blueBlue0102 Could you please check the CI error. Thanks!

Should just need to run 'go mod tidy' in shim once this is merged in.

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

craigcondit pushed a commit that referenced this pull request Dec 19, 2024
Closes: #1005

Signed-off-by: Craig Condit <ccondit@apache.org>
rhh777 pushed a commit to rhh777/yunikorn-core that referenced this pull request Dec 25, 2024
Closes: apache#1005

Signed-off-by: Craig Condit <ccondit@apache.org>
(cherry picked from commit 72a2553)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants