Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2367] Core: Add support for resource updates #959

Closed
wants to merge 2 commits into from

Conversation

craigcondit
Copy link
Contributor

What is this PR for?

Support resource updates via UpdateAllocation in the core.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2367

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 94.54545% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (e18603a) to head (28194f2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/scheduler/partition.go 81.48% 4 Missing and 1 partial ⚠️
pkg/scheduler/objects/application.go 98.21% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   80.40%   80.84%   +0.43%     
==========================================
  Files          97       97              
  Lines       12437    12512      +75     
==========================================
+ Hits        10000    10115     +115     
+ Misses       2165     2126      -39     
+ Partials      272      271       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can see too many uncovered branches in partition.go. At the very least I'd address those in a follow-up JIRA.

@craigcondit
Copy link
Contributor Author

@pbacsko Pushed updates to fix code coverage.

@craigcondit craigcondit requested a review from pbacsko September 4, 2024 16:41
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@craigcondit craigcondit deleted the YUNIKORN-2367 branch September 4, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants