[YUNIKORN-2917] Add additional buckets for latency histograms #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update latency histograms to allow buckets for larger (> 10s) values. Also update descriptions to reflect that despite the naming, the values are, in fact, specified in seconds. Existing names are retained to avoid breaking backwards compatibility.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #982 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 97 97
Lines 12625 12625
=======================================
Hits 10292 10292
Misses 2051 2051
Partials 282 282 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Update latency histograms to allow buckets for larger (> 10s) values. Also update descriptions to reflect that despite the naming, the values are, in fact, specified in seconds.
Existing names are retained to avoid breaking backwards compatibility.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2917
How should this be tested?
Screenshots (if appropriate)
Questions: