[YUNIKORN-2908] Remove associated metrics when queue is removed

[hguo25]

What is this PR for?

Delete all metrics so a deleted queue will not continue to report 'guaranteed resource' 'max resource'

What type of PR is it?

• - Bug Fix
• - Improvement
• - Feature
• - Documentation
• - Hot Fix
• - Refactoring

Todos

• - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2908

How should this be tested?

Screenshots (if appropriate)

Questions:

• - The licenses files need update.
• - There is breaking changes for older versions.
• - It needs documentation.

[pbacsko]

@hguo25 is this change ready for review? I can only see two "wip" commits. If it's not ready, please make it draft by clicking on "Convert to Draft".

[pbacsko]

Also, when ready, squash the commits into a single one and change the commit message to "[YUNIKORN-nnnn] JIRA title" format. Thanks.

[hguo25]

@pbacsko yes it's ready. Squashed commits as you asked. Please review, thanks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@5d3eb36). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #987   +/-   ##
=========================================
  Coverage          ?   81.32%           
=========================================
  Files             ?       97           
  Lines             ?    15491           
  Branches          ?        0           
=========================================
  Hits              ?    12598           
  Misses            ?     2610           
  Partials          ?      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pbacsko]

There's no coverage for the new functions in the "metrics" package. Please extend the coverage.

[craigcondit]

Approach is good, add tests (as Peter indicated).

[hguo25]

thanks @pbacsko @craigcondit I have added test

[pbacsko]

Address linter error.

Run locally with 'make lint".

[pbacsko]

+1 LGTM (pending e2e)

[hguo25]

@pbacsko thanks for the review. The e2e failed in gang scheduling, which doesn't seem to be related to my change?

[wilfred-s]

We need a follow up on YUNIKORN-2926 to fix the gang scheduling e2e test. The changes I made there are not enough to fix the whole issue. Logged new jira for that.

[craigcondit]

+1 LGTM.