[YUNIKORN-2925] Remove internal object from application REST info #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the TrackedResource object from the REST response for the application. Moved the tracked resources into a separate object inside the app DAO, as we have done for other complex pieces. Cleanup exposure of the summary object to be testing only. Add DAO retrieval of TrackedResource type for the web handler. Fixed locking inside the app when logging the summary and cleaning up.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
==========================================
+ Coverage 81.34% 81.55% +0.21%
==========================================
Files 97 97
Lines 15590 15639 +49
==========================================
+ Hits 12681 12754 +73
+ Misses 2630 2601 -29
- Partials 279 284 +5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
rhh777
pushed a commit
to rhh777/yunikorn-core
that referenced
this pull request
Nov 25, 2024
…ache#999) Remove the TrackedResource object from the REST response for the application. Moved the tracked resources into a separate object inside the app DAO, as we have done for other complex pieces. Cleanup exposure of the summary object to be testing only. Add DAO retrieval of TrackedResource type for the web handler. Closes: apache#999 Signed-off-by: Craig Condit <ccondit@apache.org> (cherry picked from commit 7c99e6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Remove the TrackedResource object from the REST response for the application. Moved the tracked resources into a separate object inside the app DAO, as we have done for other complex pieces. Cleanup exposure of the summary object to be testing only. Add DAO retrieval of TrackedResource type for the web handler.
Fixed locking inside the app when logging the summary and cleaning up.
What type of PR is it?
What is the Jira issue?
YUNIKORN-2925
How should this be tested?
Unit tests included
Questions: