[YUNIKORN-1648] Fix ginkgo v2 upgrade warnings. #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinsgateted
requested review from
manirajv06,
FrankYang0529 and
wilfred-s
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
=======================================
Coverage 71.92% 71.92%
=======================================
Files 51 51
Lines 8082 8082
=======================================
Hits 5813 5813
Misses 2073 2073
Partials 196 196 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
manirajv06
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix ginkgo v2 upgrade warnings. Just delete that ACK_GINKGO_DEPRECATIONS=2.9.0 because I didn't see any additional warnings when running
make e2e_test.What type of PR is it?
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1648
How should this be tested?
Run
make e2e_test