[YUNIKORN-2049] Fix incorrect placement rule examples #691
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
There are some useful placement rule examples under https://github.com/apache/yunikorn-k8shim/tree/master/deployments/examples/placements
while there are some incorrect settings in them:
queue.yaml
should bequeues.yaml
yunikorn.apache.org/username
is legacy and should be switched to annotationyunikorn.apache.org/user.info
Correct me if I'm wrong, the backward compatibility for the label
yunikorn.apache.org/username
seems broken. The placement rules examples in the link mentioned will not work with the label, but will only be effective with the annotation (i.e.,yunikorn.apache.org/user.info
).What type of PR is it?
Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2049
How should this be tested?
N/A
Screenshots (if appropriate)
N/A
Questions:
N/A