Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2049] Fix incorrect placement rule examples #691

Closed
wants to merge 1 commit into from

Conversation

brandboat
Copy link
Member

What is this PR for?

There are some useful placement rule examples under https://github.com/apache/yunikorn-k8shim/tree/master/deployments/examples/placements

while there are some incorrect settings in them:

  • queue.yaml should be queues.yaml
  • label yunikorn.apache.org/username is legacy and should be switched to annotation yunikorn.apache.org/user.info

Correct me if I'm wrong, the backward compatibility for the label yunikorn.apache.org/username seems broken. The placement rules examples in the link mentioned will not work with the label, but will only be effective with the annotation (i.e., yunikorn.apache.org/user.info).

What type of PR is it?

  • - Documentation

Todos

N/A

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2049

How should this be tested?

N/A

Screenshots (if appropriate)

N/A

Questions:

N/A

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #691 (a7479e9) into master (7b08702) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #691   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files          51       51           
  Lines        8105     8105           
=======================================
  Hits         5821     5821           
  Misses       2084     2084           
  Partials      200      200           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilfred-s wilfred-s closed this in e05f48b Oct 26, 2023
@brandboat brandboat deleted the YUNIKORN-2049 branch October 26, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants