Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2973] Adding GinkgoLinter Checks and fix #941

Closed

Conversation

rrajesh-cloudera
Copy link
Contributor

What is this PR for?

Add Ginkgo Linter for E2E Tests

  • Added Ginkgo linter to the .golangci.yml configuration file.
  • Configured the linter to run only for the test folder
  • Updated the code to resolve Ginkgo linter issues by replacing gomega.Expect(kubeClient.SetClient()).To(gomega.BeNil()) with gomega.Expect(kubeClient.SetClient()).To(gomega.Succeed()).

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2973

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.05%. Comparing base (31132ba) to head (8b118a7).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
+ Coverage   68.03%   68.05%   +0.02%     
==========================================
  Files          70       70              
  Lines        9194     9194              
==========================================
+ Hits         6255     6257       +2     
+ Misses       2732     2730       -2     
  Partials      207      207              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wilfred-s wilfred-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wilfred-s wilfred-s closed this in 76aaf7e Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants