Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2776] Add topology spread constraints to the admission controller #180

Closed
wants to merge 1 commit into from
Closed

[YUNIKORN-2776] Add topology spread constraints to the admission controller #180

wants to merge 1 commit into from

Conversation

jacobsalway
Copy link
Contributor

@jacobsalway jacobsalway commented Jul 30, 2024 •
edited
Loading

What is this PR for?

Add topology spread constraints to the admission controller deployment

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2776

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@jacobsalway jacobsalway changed the title Add topology spread constraints to the admission controller [YUNIKORN-2776] Add topology spread constraints to the admission controller Jul 30, 2024
@jacobsalway jacobsalway marked this pull request as ready for review July 30, 2024 04:29
guangyu-yang-rokt
guangyu-yang-rokt approved these changes Jul 30, 2024
View reviewed changes
Copy link

@guangyu-yang-rokt guangyu-yang-rokt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobsalway jacobsalway closed this by deleting the head repository Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangyu-yang-rokt guangyu-yang-rokt guangyu-yang-rokt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsalway @guangyu-yang-rokt