[YUNIKORN-2579] Remove maxAllocations from AllocationAsk #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
@craigcondit This idea is good to simplify the code base, and I notice that ExecutionTimeoutMilliSeconds seems to be unused too. Should we remove it? BTW, removing it can't simplify code base since there is no facility for it.
That would probably be best left to another PR. This one is part of an epic to merge ask and allocation. When that is done, there will likely be further optimizations / simplifications of the interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Remove maxAllocations from the AllocationAsk object so that we can enforce 1:1 mappings between asks and allocations.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2579
How should this be tested?
Screenshots (if appropriate)
Questions: