Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3023: Sync and commit diff log entries before NEWLEADER ack #1848

Closed
wants to merge 2 commits into from
Closed

ZOOKEEPER-3023: Sync and commit diff log entries before NEWLEADER ack #1848

wants to merge 2 commits into from

Commits on Jul 20, 2022

  1. ZOOKEEPER-3023: Sync and commit diff log entries before NEWLEADER ack 

    ZOOKEEPER-2678 could skip snapshot in diff sync, but diff txns are
logged and committed after NEWLEADER ack. ZOOKEEPER-3911 moves txn
logging before NEWLEADER ack, but the txn logging is asynchronous. So it
is indeterminate whether diff txns have been persisted to disk or not
after NEWLEADER ack.

This commit try to sync and commit txn logs synchronously before ack to
NEWLEADER thus provides strong guarantee that follower is in sync with
leader after NEWLEADER ack received.

This behavior is consistent with pre ZOOKEEPER-2678 and easy to test.
    @kezhuw
    kezhuw committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    b0608e0 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. fixup! ZOOKEEPER-3023: Sync and commit diff log entries before NEWLEA… 

    …DER ack
    @kezhuw
    kezhuw committed May 4, 2023
    Configuration menu
    Copy the full SHA
    aa7e625 View commit details
    Browse the repository at this point in the history