Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4655: [ADDENDUM] fix build error #2012

Conversation

kezhuw
Copy link
Member

@kezhuw kezhuw commented Jun 16, 2023

PR #1950(ZOOKEEPER-4655) was created before #1859(ZOOKEEPER-4466) merged. It changes assertEvent's signature which is depended by #1859.

This fixes master compilation failure.

cc @anmolnar @eolivelli @PapaCharlie

PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged.
It changes `assertEvent`'s signature which is depended by apache#1859.
Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tisonkun
Copy link
Member

Jenkins fails seems on a unrelated test:

QuorumSSLTest.testRollingUpgrade:598->stopAppendConfigRestartAll:618 expected: <true> but was: <false>

I don't know how to rerun it manually without push a new commit or close and reopen PR, though.

@kezhuw
Copy link
Member Author

kezhuw commented Jun 16, 2023

@tisonkun I guess @anmolnar might prefer to revert the last commit. You can checkout slack channel.

@anmolnar anmolnar changed the title hotfix: Fix testSamePathWithDifferentWatchModes compilation failure ZOOKEEPER-4655 [ADDENDUM] Build fix Jun 16, 2023
@anmolnar anmolnar changed the title ZOOKEEPER-4655 [ADDENDUM] Build fix ZOOKEEPER-4655. [ADDENDUM] fix build error Jun 16, 2023
@anmolnar anmolnar changed the title ZOOKEEPER-4655. [ADDENDUM] fix build error ZOOKEEPER-4655: [ADDENDUM] fix build error Jun 16, 2023
@kezhuw
Copy link
Member Author

kezhuw commented Jun 16, 2023

Java tests failed due to ZOOKEEPER-4704.

@tisonkun @anmolnar Could you restart it ? I have only "reopen" which will restart all ci pipelines.

@anmolnar anmolnar merged commit ca89286 into apache:master Jun 16, 2023
anmolnar pushed a commit that referenced this pull request Jun 16, 2023
PR #1950(ZOOKEEPER-4655) was created before #1859(ZOOKEEPER-4466) merged.
It changes `assertEvent`'s signature which is depended by #1859.
anurag-harness pushed a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged.
It changes `assertEvent`'s signature which is depended by apache#1859.
anurag-harness added a commit to anurag-harness/zookeeper that referenced this pull request Aug 31, 2023
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged.
It changes `assertEvent`'s signature which is depended by apache#1859.

Co-authored-by: Kezhu Wang <kezhuw@gmail.com>
rahulrane50 pushed a commit to rahulrane50/zookeeper that referenced this pull request Sep 15, 2023
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged.
It changes `assertEvent`'s signature which is depended by apache#1859.
@kezhuw kezhuw deleted the hotfix-testSamePathWithDifferentWatchModes-compilation-failure branch September 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants