-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-4655: [ADDENDUM] fix build error #2012
ZOOKEEPER-4655: [ADDENDUM] fix build error #2012
Conversation
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by apache#1859.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Jenkins fails seems on a unrelated test:
I don't know how to rerun it manually without push a new commit or close and reopen PR, though. |
Java tests failed due to ZOOKEEPER-4704. @tisonkun @anmolnar Could you restart it ? I have only "reopen" which will restart all ci pipelines. |
PR #1950(ZOOKEEPER-4655) was created before #1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by #1859.
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by apache#1859.
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by apache#1859. Co-authored-by: Kezhu Wang <kezhuw@gmail.com>
PR apache#1950(ZOOKEEPER-4655) was created before apache#1859(ZOOKEEPER-4466) merged. It changes `assertEvent`'s signature which is depended by apache#1859.
PR #1950(ZOOKEEPER-4655) was created before #1859(ZOOKEEPER-4466) merged. It changes
assertEvent
's signature which is depended by #1859.This fixes master compilation failure.
cc @anmolnar @eolivelli @PapaCharlie