Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-4020: Fix memory leak from ssl cert in c client #2209

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ZOOKEEPER-4020: Fix memory leak from ssl cert in c client #2209

wants to merge 5 commits into from

Conversation

Gowrima
Copy link

@Gowrima Gowrima commented Oct 29, 2024

Fixing memory leak by freeing memory allocated by strdup in cert_t.

kezhuw
kezhuw reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@kezhuw kezhuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right. I think it is zookeeper_close's job to free cert->ca.

zookeeper-client/zookeeper-client-c/src/zookeeper.c Outdated Show resolved Hide resolved
@kezhuw kezhuw changed the title ZOOKEEPER-4020 ZOOKEEPER-4020: Fix memory leak from ssl cert in c client Oct 30, 2024
@Gowrima
Copy link
Author

Gowrima commented Oct 30, 2024

@kezhuw Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhuw kezhuw kezhuw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gowrima @kezhuw