Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update openapi version to 3.0.0 #6924

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

shanshanying
Copy link
Contributor

@shanshanying shanshanying commented Mar 29, 2024

The generated ASTFile is incorrect in converting exclusive minimum / maximum.

image

for exampel, if we use expr >1 in cue, Exected output shoud be:

exclusiveMinimum: true
minimum: int 1

rather than

exclusiveMinimum: 1

As the issues mentioned in cue-lang community has been fixed and we checked out that we shoud use APIVersion '3.0.0' instead of '3.1.0'.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.02%. Comparing base (7d50e69) to head (aa83f25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6924      +/-   ##
==========================================
+ Coverage   66.00%   66.02%   +0.02%     
==========================================
  Files         333      333              
  Lines       41200    41200              
==========================================
+ Hits        27192    27202      +10     
+ Misses      11679    11672       -7     
+ Partials     2329     2326       -3     
Flag Coverage Δ
unittests 66.02% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanshanying shanshanying merged commit b088d60 into main Mar 29, 2024
85 checks passed
@shanshanying shanshanying deleted the bugfix/fix-cue-exclusive-minimum branch March 29, 2024 09:47
@github-actions github-actions bot added this to the Release 0.9.0 milestone Mar 29, 2024
@shanshanying
Copy link
Contributor Author

/cherry-pick release-0.8

Copy link

🤖 says: Error cherry-picking.

Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging pkg/configuration/openapi/cue_gen_openapi.go
Auto-merging test/testdata/cue_testdata/mysql_openapi.cue
error: could not apply b088d60... fix: update openapi version to 3.0.0 (#6924)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Copy link

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/apecloud/kubeblocks/actions/runs/8479686986

TalktoCrystal pushed a commit that referenced this pull request Apr 11, 2024
Co-authored-by: wusai80 <wusai80@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] failed to transform from cuelang to openapischema when exclusiveMinimum field exists for OpenApiSchema
5 participants