Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve calculate mysql buffer pool size in 0.9 #8343

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

kizuna-lek
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 28, 2024
@kizuna-lek kizuna-lek marked this pull request as ready for review October 28, 2024 09:20
@apecloud-bot apecloud-bot added the approved PR Approved Test label Oct 28, 2024
@kizuna-lek
Copy link
Collaborator Author

/approve

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.90%. Comparing base (a12dc4a) to head (a4bd848).
Report is 2 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controller/configuration/builtin_functions.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8343      +/-   ##
===============================================
+ Coverage        64.83%   64.90%   +0.07%     
===============================================
  Files              358      358              
  Lines            45310    45311       +1     
===============================================
+ Hits             29376    29411      +35     
+ Misses           13303    13274      -29     
+ Partials          2631     2626       -5     
Flag Coverage Δ
unittests 64.90% <75.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kizuna-lek kizuna-lek merged commit 6a0389f into release-0.9 Oct 28, 2024
49 checks passed
@kizuna-lek kizuna-lek deleted the bugfix/improve-mysql-bool-size-in0.9 branch October 28, 2024 09:31
@github-actions github-actions bot added this to the Release 0.9.2 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants