Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support to h-scale shard count(pick from d3029e42) #8530

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 63 lines in your changes missing coverage. Please review.

Project coverage is 64.79%. Comparing base (8350237) to head (c45b53d).

Files with missing lines Patch % Lines
controllers/apps/operations/ops_progress_util.go 64.06% 18 Missing and 5 partials ⚠️
controllers/apps/operations/ops_comp_helper.go 60.71% 14 Missing and 8 partials ⚠️
apis/apps/v1alpha1/opsrequest_webhook.go 0.00% 7 Missing and 1 partial ⚠️
controllers/apps/operations/horizontal_scaling.go 81.08% 5 Missing and 2 partials ⚠️
pkg/controllerutil/sharding_utils.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-0.9    #8530      +/-   ##
===============================================
- Coverage        64.86%   64.79%   -0.07%     
===============================================
  Files              358      358              
  Lines            45539    45655     +116     
===============================================
+ Hits             29540    29584      +44     
- Misses           13368    13433      +65     
- Partials          2631     2638       +7     
Flag Coverage Δ
unittests 64.79% <62.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei merged commit 97c8554 into release-0.9 Nov 26, 2024
18 checks passed
@wangyelei wangyelei deleted the feature/hscale_shards-count branch November 26, 2024 07:21
@github-actions github-actions bot added this to the Release 0.9.2 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant