Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: filtering v1 version events fails when no changes have been made to the ClusterDefinition. #8612

Merged
merged 8 commits into from
Dec 11, 2024
Merged

chore: filtering v1 version events fails when no changes have been made to the ClusterDefinition. #8612

merged 8 commits into from
Dec 11, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei requested review from leon-inf, Y-Rookie and a team as code owners December 9, 2024 07:29
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.36842% with 30 lines in your changes missing coverage. Please review.

Project coverage is 61.22%. Comparing base (51a60a0) to head (2b7fe7c).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/apps/transformer_cluster_normalization.go 61.53% 11 Missing and 4 partials ⚠️
apis/apps/v1alpha1/conversion.go 0.00% 13 Missing ⚠️
apis/apps/v1alpha1/cluster_conversion.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8612      +/-   ##
==========================================
+ Coverage   60.25%   61.22%   +0.96%     
==========================================
  Files         377      378       +1     
  Lines       45897    46566     +669     
==========================================
+ Hits        27656    28508     +852     
+ Misses      15634    15452     -182     
+ Partials     2607     2606       -1
Flag Coverage Δ
unittests 61.22% <47.36%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei changed the title chore: add sidecar role rbac and fix component controller error when existing 1.0 and 0.9 kb chore: add sidecar role for rbac and fix component controller error when existing 1.0 and 0.9 kb Dec 9, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 10, 2024
@wangyelei wangyelei changed the title chore: add sidecar role for rbac and fix component controller error when existing 1.0 and 0.9 kb fix: filter v1 version events failed Dec 10, 2024
@wangyelei wangyelei changed the title fix: filter v1 version events failed fix: filter v1 version events failed when the clusterDefinition name is imuatable Dec 10, 2024
@wangyelei wangyelei changed the title fix: filter v1 version events failed when the clusterDefinition name is imuatable fix: filtering v1 version events fails when no changes have been made to the ClusterDefinition. Dec 10, 2024
@wangyelei wangyelei changed the title fix: filtering v1 version events fails when no changes have been made to the ClusterDefinition. chore: filtering v1 version events fails when no changes have been made to the ClusterDefinition. Dec 10, 2024
@apecloud-bot apecloud-bot added the approved PR Approved Test label Dec 11, 2024
@wangyelei wangyelei merged commit 3d89b29 into main Dec 11, 2024
37 checks passed
@wangyelei wangyelei deleted the bugfix/add-sidecar-role branch December 11, 2024 04:06
@wangyelei
Copy link
Contributor Author

/cherry-pick release-1.0-beta

@github-actions github-actions bot added this to the Release 0.9.2 milestone Dec 11, 2024
@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/12269484330

apecloud-bot pushed a commit that referenced this pull request Dec 11, 2024
@wangyelei
chore: filtering v1 version events fails when no changes have been ma…
9c256ac 
…de to the ClusterDefinition. (#8612)

(cherry picked from commit 3d89b29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leon-inf leon-inf leon-inf approved these changes

@zjx20 zjx20 zjx20 approved these changes

@ldming ldming ldming approved these changes

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
5 participants
@wangyelei @apecloud-bot @ldming @zjx20 @leon-inf