fix: the decimal value of the default mount mode for TLS secrets #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8627 +/- ##
==========================================
+ Coverage 60.49% 60.79% +0.30%
==========================================
Files 378 378
Lines 45623 45757 +134
==========================================
+ Hits 27598 27817 +219
+ Misses 15441 15338 -103
- Partials 2584 2602 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zjx20
reviewed
Dec 12, 2024
| @@ -223,7 +223,7 @@ func (t *componentTLSTransformer) composeTLSVolume( | |||
| if compDef.Spec.TLS.DefaultMode != nil { | |||
| volume.VolumeSource.Secret.DefaultMode = ptr.To(*compDef.Spec.TLS.DefaultMode) | |||
| } else { | |||
| volume.VolumeSource.Secret.DefaultMode = ptr.To(int32(0600)) | |||
| volume.VolumeSource.Secret.DefaultMode = ptr.To(int32(384)) | |||
There was a problem hiding this comment.
Fixed. The issue is that the default value set by Kubebuilder is treated as decimal 600 by default.
There was a problem hiding this comment.
Keep this line unchanged for readability.
leon-inf
force-pushed
the
bugfix/tls-secret-default-mount-mode
branch
from
759f1e9 to
2242ae1
Compare
github-actions
bot
added
size/S
leon-inf
force-pushed
the
bugfix/tls-secret-default-mount-mode
branch
from
2242ae1 to
1606d6e
Compare
wangyelei
approved these changes
Dec 13, 2024
zjx20
approved these changes
Dec 13, 2024
|
/cherry-pick release-1.0-beta |
|
🤖 says: cherry pick action finished successfully 🎉! |
apecloud-bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
(cherry picked from commit 4e6c466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8626