Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Arrow FlightSQL #300

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat: support Arrow FlightSQL #300

merged 4 commits into from
Dec 20, 2024

Conversation

ddh-5230
Copy link
Contributor

No description provided.

@ddh-5230 ddh-5230 requested a review from fanyang01 December 19, 2024 05:36
@fanyang01 fanyang01 changed the title support flightsql feat: support Arrow FlightSQL Dec 19, 2024
Copy link
Collaborator

@fanyang01 fanyang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I've learned that DuckDB supports sqlite_master and sqlite_schema. Very interesting!

Could you please add a GitHub Workflow to test the basic functionality? E.g., use the FlightSQL Python driver ( https://arrow.apache.org/adbc/current/driver/flight_sql.html ) to connect to MyDuck's FlightSQL port and do some basic things.

@ddh-5230 ddh-5230 requested a review from fanyang01 December 20, 2024 07:33
@ddh-5230
Copy link
Contributor Author

Thanks for working on this. I've learned that DuckDB supports sqlite_master and sqlite_schema. Very interesting!

Could you please add a GitHub Workflow to test the basic functionality? E.g., use the FlightSQL Python driver ( https://arrow.apache.org/adbc/current/driver/flight_sql.html ) to connect to MyDuck's FlightSQL port and do some basic things.

I have added workflows for both Go and Python to test the basic functionality。

Copy link
Collaborator

@fanyang01 fanyang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this future-proofing PR! Arrow Flight SQL has the potential to become the dominant protocol for modern data analysis applications. This PR marks an important first step in preparing MyDuck for this transformation.

@fanyang01 fanyang01 merged commit ac2f57c into main Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants