Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support case-insensitive sorting by file names #78

Closed
glomie opened this issue Nov 24, 2017 · 4 comments · Fixed by #152
Closed

Support case-insensitive sorting by file names #78

glomie opened this issue Nov 24, 2017 · 4 comments · Fixed by #152
Assignees
@aperezdc
Labels
enhancement
Milestone
v0.5.0

Comments

@glomie
Copy link

glomie commented Nov 24, 2017

According to ascii order, the lowercase letter is bigger than the uppercase letter. For example, it shows "Afilename,Bfilename" and then "afilename". It's not suitable for me to find the file. So can you list the files ordering by ignore-case filename?
@aperezdc aperezdc added this to the v0.5.0 milestone Nov 28, 2017
@aperezdc aperezdc self-assigned this Nov 28, 2017
@aperezdc aperezdc changed the title The filename sort is not perfect. Can you improve it? Support case-insensitive sorting by file names Nov 28, 2017
@aperezdc
Copy link
Owner

@glomie: I understand that this is a feature request to support case-insensitive sorting, so am editing the issue title to make it a bit clearer. Please comment if that is not the case.

There's also issue #60 about improving sorting methods, so I will try to solve both issues together for version 0.5.0.

Thanks for your suggestion!

@glomie
Copy link
Author

glomie commented Nov 28, 2017

@aperezdc Thanks very much.Your answer is appropriate and polite.

@FredericaBernkastel
Copy link

That's too slow.
I'll make it myself.

@ryandesign
Copy link
Contributor

This has been implemented in #124.

@ryandesign ryandesign mentioned this issue Jun 3, 2022
Open
ryandesign added a commit to ryandesign/ngx-fancyindex that referenced this issue Jun 3, 2022
@ryandesign
Add case-insensitive name sorting support
bc60376 
Add the fancyindex_case_sensitive option which considers the case when
sorting by name if it is on (which it is by default to keep current
behavior) and does a case-insensitive name sort if it is off.

Closes aperezdc#78
Closes aperezdc#124

Co-authored-by: Ryan Schmidt <git@ryandesign.com>
@ryandesign ryandesign mentioned this issue Jun 3, 2022
Merged
aperezdc pushed a commit that referenced this issue Jan 20, 2023
@ryandesign @aperezdc
Add case-insensitive name sorting support
a634077 
Add the fancyindex_case_sensitive option which considers the case when
sorting by name if it is on (which it is by default to keep current
behavior) and does a case-insensitive name sort if it is off.

Closes #78
Closes #124

Co-authored-by: Ryan Schmidt <git@ryandesign.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezdc aperezdc

Labels
enhancement
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

Add case-insensitive name sorting support ryandesign/ngx-fancyindex
4 participants
@ryandesign @aperezdc @FredericaBernkastel @glomie