Add destroyDelay prop (#1085)

* fix: use on-unmounted instead of on-before-unmount * feat: add destroyDelay prop
apertureless · Apr 9, 2024 · 8d19c31 · 8d19c31
1 parent f5ffcab
commit 8d19c31
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/chart.ts b/src/chart.ts
@@ -3,7 +3,7 @@ import {
   defineComponent,
   h,
   nextTick,
-  onBeforeUnmount,
+  onUnmounted,
   onMounted,
   ref,
   shallowRef,
@@ -49,8 +49,15 @@ export const Chart = defineComponent({
       const chart = toRaw(chartRef.value)
 
       if (chart) {
-        chart.destroy()
-        chartRef.value = null
+        if (props.destroyDelay > 0) {
+          setTimeout(() => {
+            chart.destroy()
+            chartRef.value = null
+          }, props.destroyDelay)
+        } else {
+          chart.destroy()
+          chartRef.value = null
+        }
       }
     }
 
@@ -60,7 +67,7 @@ export const Chart = defineComponent({
 
     onMounted(renderChart)
 
-    onBeforeUnmount(destroyChart)
+    onUnmounted(destroyChart)
 
     watch(
       [() => props.options, () => props.data],

diff --git a/src/props.ts b/src/props.ts
@@ -44,6 +44,10 @@ export const Props = {
     type: String as PropType<ChartType>,
     required: true
   },
+  destroyDelay: {
+    type: Number,
+    default: 0 // No delay by default
+  },
   ...CommonProps,
   ...A11yProps
 } as const