Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add src folder to package.json "files" and make main "src/index.js" #49

Closed
craigh411 opened this issue Mar 1, 2017 · 2 comments
Closed

Comments

@craigh411
Copy link
Contributor

craigh411 commented Mar 1, 2017

Could you add the src folder to files in package.json, at the moment it looks like the dist file includes Vue itself, which means I'm importing Vue twice, which I only realised when I updated to Vue 2.2.1 and vue devtools was detecting Vue 2.1.10 from vue-chartjs. It's back to 2.2.1 now I've updated this package, but it looks like every time Vue realeses a new version I'm going to have to rely on you to do the same before I can update Vue in my app and that's a bit of a deal breaker.

Also, it makes sense to have src/index.js as your main file as most of us are going to be using browserify/vueify or webpack/vue-loader setups, this way we can just bundle the charts we need. I'm pretty sure you had it set up this way before and it worked great.

@craigh411 craigh411 changed the title Add src folder to package.json files and make main src/index.js Add src folder to package.json "files" and make main "src/index.js" Mar 1, 2017
@apertureless
Copy link
Owner

Sounds reasonable.
Will change it.

apertureless added a commit that referenced this issue Mar 1, 2017
* commit '562539a3a54dc89b0216d8141541501eecee1560':
  🐛 Fix #49
@apertureless
Copy link
Owner

Fixed in 2.3.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants