Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dependency and build fix #246

Merged
merged 3 commits into from
Nov 6, 2017

Conversation

apertureless
Copy link
Owner

Dependency Cleanup

  • Updated to current babel packages which are scoped with @babel
  • Added @babel/preset-env to automatically polyfill
  • Removed old babel presets

Build Script

Now there are only two dist files

  • vue-chartjs.js
  • vue-chartjs.min.js

With the webpack external fix, there is no need for two different builds.
Chart.js is defined as an external and peerDependency.

If you're using vue-chartjs with Webpack no actions are required.
If you're using vue-chart in the browser you will need to add the Chart.js CDN script.

@apertureless apertureless merged commit 2f0ab67 into develop Nov 6, 2017
@apertureless apertureless deleted the feature/dependency_and_build_fix branch December 1, 2017 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant