Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactivity to options #840

Merged
merged 3 commits into from
May 10, 2022
Merged

Add reactivity to options #840

merged 3 commits into from
May 10, 2022

Conversation

thabarbados
Copy link
Collaborator

Fix or Enhancement?

Add reactivity to options. expose chart and updateChart function
#805

  • All tests passed

Environment

  • OS: BigSur MacOs
  • NPM Version: 8.5.1

add options watcher and expose updateChart function

#805
@thabarbados thabarbados requested a review from dangreen May 5, 2022 10:37
@github-actions
Copy link

github-actions bot commented May 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.cjs 1.26 KB (+8.51% 🔺) 26 ms (+8.51% 🔺) 130 ms (-21.64% 🔽) 155 ms
dist/index.js 1.14 KB (+9.82% 🔺) 23 ms (+9.82% 🔺) 145 ms (+29.66% 🔺) 168 ms

README.md Outdated
@@ -230,7 +228,35 @@ export default {

## Reactivity

vue-chartjs will update or re-render the chart if new data is passed.
vue-chartjs will update or re-render the chart if new data or new options is passed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just leave links to the website?

https://github.com/reactchartjs/react-chartjs-2#docs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@thabarbados thabarbados requested a review from dangreen May 6, 2022 07:58
@dangreen dangreen merged commit 6f8fa51 into main May 10, 2022
@dangreen dangreen deleted the add-teactivity-to-options branch May 10, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants