Fixed mobile touch issue in pan zoom selection #4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
approved these changes
Feb 23, 2024
|
Hi.
Please update react-apexchart based on new changes.
Thank you.
…On Sat, Feb 24, 2024 at 12:06 AM Juned Chhipa ***@***.***> wrote:
Merged #4240 <#4240> into
main.
—
Reply to this email directly, view it on GitHub
<#4240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BE6N2OXZGEVTHYCID33LJP3YVD4TNAVCNFSM6AAAAABDJWUMA6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHEYDOOJWGE4DINQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This was referenced Jun 2, 2024
This was referenced Jun 9, 2024
This was referenced Jun 13, 2024
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
I debuged ZoomPanSelection.js and understand touchstart and touchend evenst are not existed.
So i tried solve this just with touchmove event!
Tested with react-apexchart examples and fortunatly it s worked.
Fixes # (issue)
Type of change
Please delete options that are not relevant.