-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved e2e test reliability #4540
Merged
junedchhipa
merged 2 commits into
apexcharts:main
from
Sebastian-Webster:tests-add-extra-wait
Jun 25, 2024
Merged
Improved e2e test reliability #4540
junedchhipa
merged 2 commits into
apexcharts:main
from
Sebastian-Webster:tests-add-extra-wait
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedchhipa
approved these changes
Jun 25, 2024
This was referenced Jul 20, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #4515 the tests passed locally, but ever since then some tests (mostly funnel/funnel, funnel/pyramid, and line/line-with-annotations) would sometimes fail spontaneously and running the tests again with no code changes would fix the error. Adding a while loop to wait for all timers/intervals/network requests and the chart animation to end fixes the reliability issues.
This change would also improve reliability for future possible tests, like for example if a test needed a timeout after the chart animation ended, the test would not wait for that timeout because it had already waited for all timeouts to finish. With this PR, if a timeout is created after a chart animation ends, the test would wait for the timeout to end before continuing.
Type of change
Checklist: