Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved e2e test reliability #4540

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

Sebastian-Webster
Copy link
Contributor

With #4515 the tests passed locally, but ever since then some tests (mostly funnel/funnel, funnel/pyramid, and line/line-with-annotations) would sometimes fail spontaneously and running the tests again with no code changes would fix the error. Adding a while loop to wait for all timers/intervals/network requests and the chart animation to end fixes the reliability issues.
This change would also improve reliability for future possible tests, like for example if a test needed a timeout after the chart animation ended, the test would not wait for that timeout because it had already waited for all timeouts to finish. With this PR, if a timeout is created after a chart animation ends, the test would wait for the timeout to end before continuing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit fd8af2d into apexcharts:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants