Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmap gaps and ticket alignment #4838

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

dschweinbenz
Copy link
Contributor

New Pull Request

Added x-axis check to include gaps into a heatmap. To be honest my code is more a "dirty fix" as i used some of the globals variables without knowing if that is the correct way to handle it. So please review the code carefully and if you know a better solution improve it.

Test:
grafik

Fixes #4809

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My branch is up to date with any changes from the main branch

@dschweinbenz dschweinbenz changed the title Fix/4809 heatmap gaps and ticket alignment Fix heatmap gaps and ticket alignment Nov 28, 2024
@junedchhipa junedchhipa merged commit e71682a into apexcharts:main Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect tick alignment in heatmap using irregular timeseries
2 participants