-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker compose on MacOS #570
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem When calling `docker compose up`, the `pwa` service fails with a strange error on MacOS: ``` pwa-1 | yarn run v1.22.22 pwa-1 | $ storybook dev -p 3000 pwa-1 | /bin/sh: 1: storybook: not found pwa-1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. pwa-1 | error Command failed with exit code 127. ``` It seems the container doesn't find the node_modules at all. ## Solution Add a second volume for the node_modules.
fzaninotto
commented
Jul 1, 2024
|
||
# copy sources | ||
COPY --link . ./ | ||
|
||
RUN set -eux; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is unrelated, but it speeds up the builds and reduces the number of layers to store.
dunglas
approved these changes
Jul 2, 2024
It seems my change makes the build fail on Linux for another developer:
Docker is NOT portable at all... I'm currently investigating. |
djhi
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When calling
docker compose up
, thepwa
service fails with a strange error on MacOS:It seems the container doesn't find the node_modules at all.
Solution
Add a second volume for the node_modules.