Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS build #571

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix TS build #571

merged 2 commits into from
Jul 2, 2024

Conversation

fzaninotto
Copy link
Contributor

@fzaninotto fzaninotto commented Jul 1, 2024

Problem

The dependencies aren't fixed by a lock file, so builds can break without any change in the codebase. It happened in a7827cb. main is currently broken.

Solution

  1. Fix latest TS errors
  2. Add a lockfile so that it doesn't happen again.
Q A
Branch? main for features / current stable version branch for bug fixes
Tickets Closes #..., closes #...
License MIT
Doc PR api-platform/docs#...

## Problem

The dependencies aren't fixed by a lock file, so builds can break without any change in the codebase

## Solution

1. Fix latest TS errors
2. Add a lockfile
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fzaninotto !

@fzaninotto fzaninotto merged commit 969ecc2 into main Jul 2, 2024
4 checks passed
@fzaninotto fzaninotto deleted the fix-ts-build branch July 2, 2024 08:02
@fzaninotto fzaninotto added this to the v3.48.9 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants