Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for react-admin v5 #572

Merged
merged 18 commits into from
Jul 11, 2024
Merged

Add support for react-admin v5 #572

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3358223
[WIP] Add support for react-admin v5
fzaninotto Jul 2, 2024
3704e6e
Fix more TS errors
fzaninotto Jul 2, 2024
9369825
Fix build
fzaninotto Jul 3, 2024
526e46c
Fix linter warnings
fzaninotto Jul 3, 2024
1dfad83
Fix one test
fzaninotto Jul 3, 2024
061b5c9
fix jest config for react-query
slax57 Jul 8, 2024
e12cd7f
InputGuesser: fix array label and test
slax57 Jul 8, 2024
c99a968
Add folder hierarchy
fzaninotto Jul 9, 2024
bcc26c8
Fix tests
fzaninotto Jul 9, 2024
746843a
Add sort and filter to the test entity
fzaninotto Jul 10, 2024
b6cc2a8
Modernize override code
fzaninotto Jul 10, 2024
c057be9
Fix console error
fzaninotto Jul 10, 2024
d1b4893
Fix override code
fzaninotto Jul 10, 2024
213badd
Add stroy testing view customization
fzaninotto Jul 10, 2024
b15efb6
Bump version
fzaninotto Jul 10, 2024
14ecb27
Apply suggestions from code review
fzaninotto Jul 10, 2024
3f35eb2
Update .dockerignore
fzaninotto Jul 10, 2024
f5e1062
Apply suggestion from code review
fzaninotto Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ const config: JestConfigWithTsJest = {
moduleNameMapper: {
'^(\\.{1,2}/.*/llhttp\\.wasm\\.js)$': '$1',
'^(\\.{1,2}/.*)\\.js$': '$1',
'^@tanstack/react-query$':
'<rootDir>/node_modules/@tanstack/react-query/build/modern/index.cjs',
Comment on lines +12 to +13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, Jest resolved imports to @tanstack/react-query to the ESM code when imported from the test file, and to the CJS code when imported from ra-core. This caused the issue about QueryClient because the references to the context object were not equal.

This line forces the resolution to the CJS code all the time, which solves the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a problem react-admin users may be facing, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it could be, if they are using Jest with NODE_OPTIONS=--experimental-vm-modules. But I'm not sure it's react-admin's responsibility to document this, as this rather looks like a Jest bug to me...

},
transform: {
'^.+\\.tsx?$': [
Expand Down