[2.3] Throw an InvalidArgument when trying to get Item from a collection route #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antograssiot
changed the title
soyuka
approved these changes
Sep 28, 2018
|
Nice DX improvement! Thanks @antograssiot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the search filter on an exact association for example, if the obviously bad value is a matching collection url, the filter IriConverter will throw
Either \"item_operation_name\" or \"collection_operation_name\" must be defined, unless the \"_api_receive\" request attribute is set to false.This is because
getItemFromIri()will get a match on the router but won't match the expected the attributes.an easy way to reproduce this on the demo is to try to filter
/reviews?book=fooversus/reviews?book=parchmentsor/reviews?book=book