Persist doctrine entities with DEFERRED_EXPLICIT change tracking policy

[paxal]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	maybe
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2155
License	MIT
Doc PR	~

As reported in #2155 doctrine entities are not persisted if change tracking policy is DEFERRED_EXPLICIT.

This implementation relies on ClassMetadataInfo, which is the ClassMetadata implementation. As it's API might change, I've added a test on method existence.

[soyuka]

Thanks @paxal !

[paxal]

Thanks for your quick merge :)

[backbone87]

why not just unconditionally call persist? there is no reason to do extra checks besides supports, doctrine will handle all special cases.

[soyuka]

according to #2155 it does not?

[backbone87]

The problem is the contains call, which prevents the persist call for existing (but changed) entities. Just drop the whole condition around the persist and let doctrine do the checks (which It does anyway when persist is called)

[soyuka]

The contains was added in #1782, reasons are stated there.

[backbone87]

I dont get the resoning there. What is meant with „Changes from the outside“ and how does a persist call override them. This sounds to me more like a missuse of doctrine. Persist calls should never override anything: https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/working-with-objects.html#working-with-objects

[soyuka]

Mhh I think that it's in case of relations there were issues when persisting updated ones. Anyway, Doctrine doesn't check for contains and we definitely don't want to persist entities that aren't managed. From what I see in the UnitOfWork, persist doesn't do the check contains does. Also, the persist doc states:

NOTE: The persist operation always considers entities that are not yet known to this EntityManager as NEW. Do not pass detached entities to the persist operation.

[backbone87]

I think you missread the condition. Persist is called, when the uow does not contain the entity already