Normalize non-resource objects in a standalone normalizer #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teohhanhui
requested review from
dunglas,
soyuka,
meyerbaptiste,
antograssiot and
alanpoulain
teohhanhui
force-pushed
the
fix/normalize-non-resource
branch
from
ec28e96 to
d2b4e71
Compare
This was referenced Apr 2, 2019
teohhanhui
commented
Apr 2, 2019
features/main/input_output.feature
Outdated
| @@ -179,7 +179,11 @@ Feature: DTO input and output | |||
| }, | |||
| "@type": "User", | |||
| "@id": "/users/1", | |||
| "dummy": "/dummies/1" | |||
| "dummy": { | |||
There was a problem hiding this comment.
This should probably be handled better?
There was a problem hiding this comment.
It'd be better to have @id as a string no?
|
seems cleaner (and better performance, I hope) |
This was referenced Apr 3, 2019
soyuka
force-pushed
the
fix/normalize-non-resource
branch
2 times, most recently
from
18d5360 to
ecacda5
Compare
|
when using |
|
@teohhanhui my test case also covers @toriqo issue, should I duplicate it to make it run with other formats? |
|
@soyuka I'll take care of that, since I've been working on something since yesterday. |
teohhanhui
force-pushed
the
fix/normalize-non-resource
branch
3 times, most recently
from
4812d4e to
d9bb3c1
Compare
soyuka
approved these changes
Apr 5, 2019
soyuka
reviewed
Apr 5, 2019
+100 |
teohhanhui
force-pushed
the
fix/normalize-non-resource
branch
3 times, most recently
from
31ea473 to
2893263
Compare
teohhanhui
force-pushed
the
fix/normalize-non-resource
branch
from
2893263 to
8f27927
Compare
teohhanhui
force-pushed
the
fix/normalize-non-resource
branch
from
8f27927 to
521fa98
Compare
|
Thanks @teohhanhui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Includes a minor BC break because we undo a new change introduced in 2.4. I think it's okay because
$handleNonResourcewas internal anyway. The only people affected would be those who have extendedAbstractItemNormalizerand explicitly pass that optional parameter (which, actually, still wouldn't result in an error anyway).TODO:
Handle circular reference across resource / non-resource?Don't care for now