Add a flag to allow an opt-out from AddTagsListener #4327
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that at each request this
ApiPlatform\Core\HttpCache\EventListener\AddTagsListener
addsCache-Tags
just before returning the response. For large interconnected entities this can have unexpected consequences and it should really be an opt-in listener in my mind. In my case for example I have https://linkerd.io/ limiting infra service communication headers to 12k. On each get because of this listener I have bigger than 12k headers for specific "big" linked resources ... this happens on GET(s) too! For backward compatibility though I added a flag so that by default is turned on but can be turned off easily underhttp_cache
config.