-
-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add compatibility with doctrine/orm 3.0 #6156
Conversation
7e20f07
to
028aff4
Compare
nice! can you run the doctrine orm component tests? Also it looks like phpstan isn't happy |
028aff4
to
ea4dcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fine from my side but phpstan only to be resolved :)
ea4dcb2
to
352c4c0
Compare
Solved some problems, but others are popping up. Is there any documentation on how to run the tests and checks locally? |
Hi, thanks for the patch, I guess that our |
waiting for symfony/symfony@ac07f3e |
@soyuka You need this commit in a release? If yes, which branch do you need (5.4, 6.4, 7.0, the three of them)? |
@fabpot yes 6.4 and 7.0 would be great but I'd like to be sure it's the only blocker |
Thanks @ddeboer fo starting this went on my branch to continue as gh actions was buggy |
My pleasure @soyuka. Thank you for wrapping this up. |
Introduce compatibility with doctrine/orm 3.0.