Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary comments #6408

Merged

Conversation

ttskch
Copy link
Contributor

@ttskch ttskch commented Jun 4, 2024

Q A
Branch? 3.3
Tickets N/A
License MIT
Doc PR N/A

This commit added many @noRector comments, but it is strange that the @noRector comments remain even though rector.php itself was removed in this commit. This PR removes those unnecessary @noRector comments.

Regards.

@ttskch ttskch changed the base branch from main to 3.3 June 4, 2024 07:56
Copy link

stale bot commented Aug 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 3, 2024
@stale stale bot removed the stale label Aug 3, 2024
@soyuka soyuka merged commit d7a5d54 into api-platform:3.3 Aug 8, 2024
67 of 76 checks passed
@ttskch ttskch deleted the docs/remove-unnecessary-norector-comments branch August 8, 2024 23:51
soyuka added a commit that referenced this pull request Aug 9, 2024
* tests: remove output suffix after reverting

* cs: remove unnecessary comments (#6408)

* fix(elasticsearch): change normalize return type to compatible with other normalizers (#6493)

* style: various cs fixes (#6504)

* cs: fixes

* chore: phpstan fixes

* style: cs fixes

---------

Co-authored-by: Takashi Kanemoto <4360663+ttskch@users.noreply.github.com>
Co-authored-by: Koen Pasman <118996061+Koenstell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants