Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: openapi converter generated route missing service id #106

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

bzp2010
Copy link
Collaborator

@bzp2010 bzp2010 commented Jan 8, 2024

Description

The OpenAPI converter contains an incorrect implementation that does not properly associate the converted generated routes with the service.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible

@bzp2010 bzp2010 added the bug Something isn't working label Jan 8, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 8, 2024

CLA assistant check
All committers have signed the CLA.

@bzp2010 bzp2010 changed the title fix: openapi converter generated route missing service_id fix: openapi converter generated route missing service id Jan 8, 2024
@bzp2010
Copy link
Collaborator Author

bzp2010 commented Jan 9, 2024

Ready for Review, where most of the changes are pointless code that gopls pointed out were optimized away.

The core modification is to set the service id to the route object.

There was also the historical E2E test issue where rate limiting wasn't working, I forced a new limiter to be created by means of _vid and it worked. But this has nothing to do with the converter, as no code has been changed about the converter and I don't know the reasons.

@juzhiyuan juzhiyuan merged commit 29f2570 into api7:main Jan 9, 2024
8 checks passed
bzp2010 added a commit to bzp2010/adc that referenced this pull request Jul 12, 2024
bzp2010 added a commit to bzp2010/adc that referenced this pull request Jul 12, 2024
bzp2010 added a commit to bzp2010/adc that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants