chore: update output for diff #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
pottekkat
suggested changes
Sep 22, 2023
There was a problem hiding this comment.
For diff the summary could be:
Summary: create 0, update 1, delete 0
And for sync it could remain the same:
Summary: created 0, updated 1, deleted 0
And instead of diff service: "httpbin-service" at the start, it could be updates <resource name>.
Both of these suggested changes will help show the user that these changes will happen if they chose to sync this more clearly.
The rest of the changes make things much better. Thanks!
Signed-off-by: Ling Samuel (WSL) <lingsamuelgrace@gmail.com>
tao12345666333
approved these changes
Sep 22, 2023
|
all comments are fixed. I will merge this one. Thanks |
bzp2010
added a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
bzp2010
pushed a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
bzp2010
added a commit
to bzp2010/adc
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #54
Checklist