New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary patch #88

Open

shreemaan-abhishek wants to merge 1 commit into main from fix-macos

Member

shreemaan-abhishek commented Mar 24, 2024 •

edited

Loading

This patch is no longer needed as the upstream openresty ngx-lua module already contains this fix.
https://github.com/openresty/lua-nginx-module/blob/45db94a3440a12165b8d64495a4b5dd78678214f/src/ngx_http_lua_headers.c#L1324

Compiling apisix-runtime without removing this patch results in following error:

../ngx_lua-0.10.26/src/ngx_http_lua_headers.c:1345:1: error: redefinition of 'ngx_http_lua_ffi_set_resp_header_macos'
ngx_http_lua_ffi_set_resp_header_macos(ngx_http_lua_set_resp_header_params_t *p)


          fix: remove unnecessary patch

540bd17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet