-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configurable number of bits #2
Conversation
rockspec/snowflake-2.1-0.rockspec
Outdated
@@ -0,0 +1,28 @@ | |||
package = "snowflake" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new package requires a "api7-" prefix, like this one: https://github.com/api7/lua-resty-http/blob/master/api7-lua-resty-http-0.1.0-0.rockspec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the c library need to add a prefix? If someone uses snowflake.so, there may still be conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fine, nobody will use two snowflake libraries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can change the default value of SNOWFLAKE_EPOC
back to the original value, so that it can still be compatible with the original library.
1609459200000 => 1413817200000
2021-01-01T00:00:00.000Z => 2014-10-20T15:00:00.000Z
Would you spend some time to make a 2.1 release? Thanks! |
done |
apache/apisix#4209