Merge pull request #1374 from apiaryio/honzajavorek/fix-empty-hooks

Do not initiate hooks if there are no hookfiles
apiaryio · May 22, 2019 · b7cfb1b · b7cfb1b
2 parents 1915116 + 0da05fb
commit b7cfb1b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/addHooks.js b/lib/addHooks.js
@@ -42,6 +42,11 @@ module.exports = function addHooks(runner, transactions, callback) {
     runner.hooks.transactions[transaction.name] = transaction;
   });
 
+  // No hooks
+  if (!runner.configuration.hookfiles || !runner.configuration.hookfiles.length) {
+    return callback();
+  }
+
   // Loading hookfiles from fs
   let hookfiles;
   try {

diff --git a/test/unit/addHooks-test.js b/test/unit/addHooks-test.js
@@ -74,6 +74,9 @@ describe('addHooks()', () => {
 
   it('sets transactionRunner.hooks.configuation', (done) => {
     const transactionRunner = createTransactionRunner();
+    transactionRunner.configuration.hookfiles = [
+      './hooks.js',
+    ];
 
     addHooks(transactionRunner, [], (err) => {
       assert.deepEqual(
@@ -83,4 +86,15 @@ describe('addHooks()', () => {
       done(err);
     });
   });
+
+  it('skips hooks loading when there are no hookfiles', (done) => {
+    const transactionRunner = createTransactionRunner();
+    transactionRunner.configuration.hookfiles = [];
+    transactionRunner.configuration.language = 'python';
+
+    addHooks(transactionRunner, [], (err) => {
+      assert.isUndefined(transactionRunner.hooks.configuration);
+      done(err);
+    });
+  });
 });