Release 2.3 - Support NodeJS 16+, Update drafter to 5.1 #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove support for Node <10
kylef
commented
May 18, 2023
| "drafter/ext/snowcrash/ext/markdown-parser/ext/sundown/html/*.c", | ||
| "drafter/ext/snowcrash/ext/markdown-parser/ext/sundown/html/*.h", | ||
| "drafter/ext/variant/include/mpark/*.hpp" | ||
| "drafter/packages/drafter/src/*.cc", |
There was a problem hiding this comment.
Drafter sources have been significantly altered in apiaryio/drafter#782, updating the submodule means these file lists have to be updated.
The smoke tests show that a packaged npm package is build-able, this shows that it contains all the needed files (most importantly, it proves that this list is correct).
kylef
commented
May 18, 2023
| }, | ||
| "scripts": { | ||
| "build": "node-gyp build", | ||
| "prepack": "cp drafter/THIRD_PARTY_LICENSES.txt THIRD_PARTY_LICENSES.txt", | ||
| "test:exclude-await": "mocha --exclude test/await-test.js", | ||
| "test:await": "mocha", | ||
| "test": "node --version | grep -q -E \"v(4|6)\" && npm run test:exclude-await || npm run test:await" | ||
| "test": "npm run test:await" |
There was a problem hiding this comment.
When async/await support had been added to Protagonist it was only usable in NodeJS >6 (since Node <=6 doesn't support async/await). As we've dropped support, this expression to not run async-await tests are no longer needed.
This encompasses the following changes:
Feature: overload deprecated AccessorSignatures (#943) 7f9ceb80fbc45c9ba1a10e6591ccbef9e8dee6b4
Feature: Add support for Node 18 (#937) 16fa32231e2ccd89d2804b3f765319128b20c4ac
Feature: add ScriptOrigin (#918) d09debf9eeedcb7ca4073e84ffe5fbb455ecb709
Bugfix: fix gcc 8 function cast warning (#899) 35f0fab205574b2cbda04e6347c8b2db755e124f
Bugfix: use GetBackingStore() instead of GetContents() (#888) 2c023bd447661a61071da318b0ff4003c3858d39
Feature: Add missing methods to Nan::Maybe (#852) 4e962489fb84a184035b9fa74f245f650249aca6
Mocha/Chai has known security issues, this update makes npm audit happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Why:
Criticality:
Medium.
Blast radius:
Medium - This change does not change API or ABI compatibility. However it does drop support for Node 12 and older.
Expected outcome:
Potential impact and visibility:
No expected impact.
Test results:
Smoke tests pass (provides the npm bundle would be buildable) and unit and functional tests pass on various NodeJS versions on both Linux and MacOS. Unable to test on Windows.