Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup worker stuff from memory storage to fix vitest #2004

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: cleanup worker stuff from memory storage to fix vitest #2004

merged 2 commits into from
Jul 24, 2023

Conversation

vladfrangu
Copy link
Member

@vladfrangu vladfrangu commented Jul 21, 2023 •
edited by B4nan
Loading

Closes #1999

@vladfrangu vladfrangu added the debt Code quality improvement or decrease of technical debt. label Jul 21, 2023
@vladfrangu vladfrangu requested a review from B4nan July 21, 2023 14:41
B4nan
B4nan approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise looking good

@B4nan B4nan changed the title chore: cleanup worker stuff from memory storage fix: cleanup worker stuff from memory storage to fix vitest Jul 24, 2023
@B4nan B4nan merged commit d2e098c into master Jul 24, 2023
@B4nan B4nan deleted the chore/cleanup-memory-storage-workers branch July 24, 2023 08:50
@MentalGear
Copy link

Awesome, thanks for your work on this guys!
Would you be able to push a new patch version soon to make crawlee work with vitest?

@B4nan
Copy link
Member

B4nan commented Jul 24, 2023

We will do a release later this week. You can use the beta version, every commit to master is published to NPM automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
debt Code quality improvement or decrease of technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Add Testing Unit Guide (jest/vitest)
3 participants
@vladfrangu @MentalGear @B4nan