Added new header to capture customattributes #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theganyo
requested changes
Mar 8, 2023
theganyo
requested changes
Mar 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #402 +/- ##
===================================
+ Coverage 89% 89% +1%
===================================
Files 9 9
Lines 762 768 +6
===================================
+ Hits 674 680 +6
Misses 46 46
Partials 42 42
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
theganyo
reviewed
Mar 9, 2023
| @@ -56,6 +57,11 @@ func encodeExtAuthzMetadata(api string, ac *auth.Context, authorized bool) *stru | |||
| headerOrganization: stringValueFrom(ac.Organization()), | |||
| headerScope: stringValueFrom(strings.Join(ac.Scopes, " ")), | |||
| } | |||
|
|
|||
| if ac.CustomAttributes != "" { | |||
There was a problem hiding this comment.
Just one more quick thing: Could you please add a test to verify that this header isn't added when there is no value?
…butes if it is not set in the claims in remoteservice proxy
theganyo
approved these changes
Mar 9, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.