operation shares product quota unless override #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
===================================
+ Coverage 84% 84% +1%
===================================
Files 28 28
Lines 1656 1657 +1
===================================
+ Hits 1383 1384 +1
Misses 159 159
Partials 114 114
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rockspore
previously approved these changes
Jun 1, 2023
rockspore
reviewed
Jun 1, 2023
product/product.go
Outdated
| ao := AuthorizedOperation{ | ||
| ID: fmt.Sprintf("%s-%s-%s-%s", p.Name, env, authContext.Application, oc.ID), | ||
| ID: fmt.Sprintf("%s-%s-%s-%s", p.Name, env, authContext.Application, oc.APISource), |
There was a problem hiding this comment.
This ID is still different from the one on line 352, IIUC that's not sharing the same product-level quota bucket?
There was a problem hiding this comment.
Thank you! Yes, it absolutely should be the same.
rockspore
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132