Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra cuboid downloads #22

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Conversation

j6k4m8
Copy link
Member

@j6k4m8 j6k4m8 commented May 18, 2020

...i'm ashamed

@j6k4m8 j6k4m8 requested a review from movestill May 18, 2020 23:00
@j6k4m8
Copy link
Member Author

j6k4m8 commented May 18, 2020

Nope, that wasn't it. Actually.... @movestill — i'm having a hard time getting the same results; i THINK it's just downloading what it needs..?

@j6k4m8 j6k4m8 marked this pull request as draft May 18, 2020 23:04
@movestill
Copy link
Member

If I took an empty cache and downloaded less than a cuboid, say 0:128, 0:128, 0:16, I'm pretty sure I saw an extra cuboid in the positive direction along each axis.

I'll try again later. I haven't been able to get myself to do any Rust after hours. Django upgrades having been crushing my soul!

@j6k4m8 j6k4m8 force-pushed the fix-obo-extra-cuboid-downloads branch from bf85c79 to 909afe3 Compare July 31, 2020 16:43
@movestill
Copy link
Member

I almost couldn't remember the cargo run command today! 😁

Looks like rocket isn't building in CI now, though. 😢 Think something changed with the nightly Rust build. CI is configured to use the latest nightly build.

@j6k4m8
Copy link
Member Author

j6k4m8 commented Aug 2, 2020 via email

@movestill
Copy link
Member

Nice, it’ll be good to switch to stable. IIRC correctly, it was something with macros that required nightly? Need to see if diesel requires nightly. It does some fancy stuff with macros, too.

@j6k4m8 j6k4m8 marked this pull request as ready for review September 2, 2020 15:59
@j6k4m8 j6k4m8 merged commit 1f6b6ed into master Sep 4, 2020
@j6k4m8 j6k4m8 deleted the fix-obo-extra-cuboid-downloads branch September 4, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants