Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEBUG: Properly update _greatest_backbone_count #37

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

nobutoba
Copy link
Contributor

The current implementation forgets updating _greatest_backbone_count within the get_next_backbone_candidates() function.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9be813) 99.27% compared to head (a5165a1) 99.27%.

❗ Current head a5165a1 differs from pull request most recent head dc4589e. Consider uploading reports for the commit dc4589e to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files           4        4           
  Lines         550      551    +1     
=======================================
+ Hits          546      547    +1     
  Misses          4        4           
Files Coverage Δ
grandiso/__init__.py 98.44% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j6k4m8
Copy link
Member

j6k4m8 commented Oct 29, 2023

AWESOME, thank you for the super attentive catch and bugfix, @nobutoba!! I really appreciate you contributing to the repo :)

@j6k4m8 j6k4m8 merged commit 7ff3562 into aplbrain:master Oct 29, 2023
5 checks passed
@nobutoba
Copy link
Contributor Author

I'm having fun reading the code. Thank you for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants