Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant invoke of trySyncFromUpstream #3699

Merged
merged 1 commit into from
May 21, 2021

Conversation

Technoboy-
Copy link
Contributor

Fix #3698

@github-actions
Copy link

github-actions bot commented May 21, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

kezhenxu94
kezhenxu94 previously approved these changes May 21, 2021
@kezhenxu94 kezhenxu94 added the chore Project chores such as CI settings, typos, etc. label May 21, 2021
@kezhenxu94 kezhenxu94 added this to the 1.8.0 milestone May 21, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3699 (08524d9) into master (0fb159f) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3699      +/-   ##
============================================
- Coverage     51.02%   50.98%   -0.04%     
+ Complexity     2336     2335       -1     
============================================
  Files           449      449              
  Lines         14034    14033       -1     
  Branches       1426     1426              
============================================
- Hits           7161     7155       -6     
- Misses         6384     6388       +4     
- Partials        489      490       +1     
Impacted Files Coverage Δ Complexity Δ
...rk/apollo/internals/LocalFileConfigRepository.java 77.30% <ø> (-0.16%) 27.00 <0.00> (ø)
...llo/configservice/controller/ConfigController.java 95.29% <100.00%> (ø) 26.00 <0.00> (ø)
...gservice/service/config/AbstractConfigService.java 94.11% <100.00%> (ø) 9.00 <0.00> (ø)
...ework/apollo/internals/RemoteConfigRepository.java 86.25% <0.00%> (-3.13%) 24.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb159f...08524d9. Read the comment docs.

@Technoboy-
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@kezhenxu94 kezhenxu94 merged commit f41a73b into apolloconfig:master May 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2021
@nobodyiam nobodyiam modified the milestones: 1.8.0, 1.9.0 May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Project chores such as CI settings, typos, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant invoke of trySyncFromUpstream
4 participants