Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'openjdk:8-jre-alpine' potentially causing wrong number of cpu cores #4475

Merged
merged 45 commits into from
Jul 21, 2022

Conversation

klboke
Copy link
Contributor

@klboke klboke commented Jul 20, 2022

What's the purpose of this PR

fix(#4474):'openjdk:8-jre-alpine' potentially causing wrong number of cpu cores

klboke and others added 30 commits May 16, 2019 11:07
@klboke klboke requested a review from nobodyiam July 20, 2022 11:10
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #4475 (23abcbd) into master (afad056) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4475      +/-   ##
============================================
+ Coverage     53.54%   53.57%   +0.03%     
- Complexity     2688     2691       +3     
============================================
  Files           488      488              
  Lines         15229    15229              
  Branches       1587     1587              
============================================
+ Hits           8154     8159       +5     
+ Misses         6515     6513       -2     
+ Partials        560      557       -3     
Impacted Files Coverage Δ
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...nfigservice/service/AccessKeyServiceWithCache.java 84.69% <0.00%> (+2.04%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 89.18% <0.00%> (+5.40%) ⬆️

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2d74140 into apolloconfig:master Jul 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2022
@nobodyiam nobodyiam added this to the 2.1.0 milestone Feb 5, 2023
@klboke klboke deleted the docker branch March 20, 2023 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants