Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 2.0 and upgrade to react-16 #79

Merged
merged 6 commits into from
Oct 18, 2017
Merged

support 2.0 and upgrade to react-16 #79

merged 6 commits into from
Oct 18, 2017

Conversation

jbaxleyiii
Copy link
Contributor

@jbaxleyiii jbaxleyiii commented Oct 12, 2017

This updates the dev tools to support Apollo Client 2.0 (requires apollo-client 1.* or ^2.0.0-rc.2)

@jbaxleyiii jbaxleyiii changed the title support 2.0 and update prop-types support 2.0 and upgrade to react-16 Oct 12, 2017
@peggyrayzis
Copy link
Contributor

Just tested with Githunt. Queries, mutations, and the store look good to go, but for some reason, GraphiQL is showing schema not found. If you try to run a query, no data comes back. 😢

githunt

Copy link
Contributor

@peggyrayzis peggyrayzis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we figure out how to integrate warnings into app/checkVersions, I think we are good to go. Thanks for fixing this, so happy it's finally working! 🎉

@jbaxleyiii
Copy link
Contributor Author

@ramyanaga would you be able to take a look at this as well?

@ramyanaga
Copy link
Contributor

It looks good to me! Also tested it against githunt, and didn't run into the error Peggy was getting

@ramyanaga ramyanaga closed this Oct 15, 2017
@jbaxleyiii jbaxleyiii reopened this Oct 18, 2017
@jbaxleyiii jbaxleyiii merged commit f776432 into master Oct 18, 2017
@jbaxleyiii jbaxleyiii deleted the 2.0 branch October 18, 2017 18:23
@glasser
Copy link
Member

glasser commented Oct 25, 2017

FWIW I'm getting the error Peggy saw. I filed it as #81.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants